[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0? 0/6] extern "C" overhaul for C++ files
From: |
no-reply |
Subject: |
Re: [PATCH for-6.0? 0/6] extern "C" overhaul for C++ files |
Date: |
Fri, 16 Apr 2021 07:03:48 -0700 (PDT) |
Patchew URL:
20210416135543.20382-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20210416135543.20382-1-peter.maydell@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210416135543.20382-1-peter.maydell@linaro.org
Subject: [PATCH for-6.0? 0/6] extern "C" overhaul for C++ files
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210415104426.9860-1-valeriy.vdovin@virtuozzo.com
-> patchew/20210415104426.9860-1-valeriy.vdovin@virtuozzo.com
* [new tag] patchew/20210416135543.20382-1-peter.maydell@linaro.org ->
patchew/20210416135543.20382-1-peter.maydell@linaro.org
Switched to a new branch 'test'
30f73ae include/disas/dis-asm.h: Handle being included outside 'extern "C"'
cbe3886 include/qemu/bswap.h: Handle being included outside extern "C" block
ff73f93 osdep: Make os-win32.h and os-posix.h handle 'extern "C"' themselves
ffb5bfc include/qemu/osdep.h: Move system includes to top
9c63702 osdep: protect qemu/osdep.h with extern "C"
bddc566 osdep: include glib-compat.h before other QEMU headers
=== OUTPUT BEGIN ===
1/6 Checking commit bddc5664e21c (osdep: include glib-compat.h before other
QEMU headers)
2/6 Checking commit 9c6370297ba2 (osdep: protect qemu/osdep.h with extern "C")
WARNING: architecture specific defines should be avoided
#76: FILE: include/qemu/compiler.h:14:
+#ifdef __cplusplus
ERROR: storage class should be at the beginning of the declaration
#77: FILE: include/qemu/compiler.h:15:
+#define QEMU_EXTERN_C extern "C"
ERROR: storage class should be at the beginning of the declaration
#79: FILE: include/qemu/compiler.h:17:
+#define QEMU_EXTERN_C extern
WARNING: architecture specific defines should be avoided
#102: FILE: include/qemu/osdep.h:121:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#113: FILE: include/qemu/osdep.h:735:
+#ifdef __cplusplus
total: 2 errors, 3 warnings, 56 lines checked
Patch 2/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/6 Checking commit ffb5bfccb8a2 (include/qemu/osdep.h: Move system includes to
top)
WARNING: architecture specific defines should be avoided
#34: FILE: include/qemu/osdep.h:111:
+#if defined(__linux__) && defined(__sparc__)
WARNING: architecture specific defines should be avoided
#46: FILE: include/qemu/osdep.h:123:
+#ifdef __APPLE__
total: 0 errors, 2 warnings, 50 lines checked
Patch 3/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/6 Checking commit ff73f933ce67 (osdep: Make os-win32.h and os-posix.h handle
'extern "C"' themselves)
WARNING: architecture specific defines should be avoided
#42: FILE: include/qemu/osdep.h:142:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#57: FILE: include/sysemu/os-posix.h:41:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#68: FILE: include/sysemu/os-posix.h:99:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#81: FILE: include/sysemu/os-win32.h:33:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#92: FILE: include/sysemu/os-win32.h:201:
+#ifdef __cplusplus
total: 0 errors, 5 warnings, 56 lines checked
Patch 4/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/6 Checking commit cbe3886050e1 (include/qemu/bswap.h: Handle being included
outside extern "C" block)
WARNING: architecture specific defines should be avoided
#47: FILE: include/qemu/bswap.h:18:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#84: FILE: include/qemu/bswap.h:511:
+#ifdef __cplusplus
total: 0 errors, 2 warnings, 55 lines checked
Patch 5/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/6 Checking commit 30f73aec5814 (include/disas/dis-asm.h: Handle being
included outside 'extern "C"')
WARNING: architecture specific defines should be avoided
#57: FILE: include/disas/dis-asm.h:14:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#77: FILE: include/disas/dis-asm.h:515:
+#ifdef __cplusplus
total: 0 errors, 2 warnings, 46 lines checked
Patch 6/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20210416135543.20382-1-peter.maydell@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210416135543.20382-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH for-6.0? 4/6] osdep: Make os-win32.h and os-posix.h handle 'extern "C"' themselves, (continued)
- [PATCH for-6.0? 4/6] osdep: Make os-win32.h and os-posix.h handle 'extern "C"' themselves, Peter Maydell, 2021/04/16
- [PATCH for-6.0? 1/6] osdep: include glib-compat.h before other QEMU headers, Peter Maydell, 2021/04/16
- [PATCH for-6.0? 6/6] include/disas/dis-asm.h: Handle being included outside 'extern "C"', Peter Maydell, 2021/04/16
- [PATCH for-6.0? 5/6] include/qemu/bswap.h: Handle being included outside extern "C" block, Peter Maydell, 2021/04/16
- Re: [PATCH for-6.0? 0/6] extern "C" overhaul for C++ files,
no-reply <=
- Re: [PATCH for-6.0? 0/6] extern "C" overhaul for C++ files, Philippe Mathieu-Daudé, 2021/04/16
- Re: [PATCH for-6.0? 0/6] extern "C" overhaul for C++ files, Paolo Bonzini, 2021/04/16