Re: [PATCH 2/4] Do not include hw/boards.h if it's not really necessary

[Philippe Mathieu-Daudé]

Hi Thomas,

On 4/16/21 7:13 PM, Thomas Huth wrote:
> Stop including hw/boards.h in files that don't need it.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  accel/tcg/tcg-accel-ops-icount.c | 1 -
>  accel/tcg/tcg-accel-ops-rr.c     | 1 -
>  accel/tcg/tcg-accel-ops.c        | 1 -
>  hw/acpi/cpu.c                    | 1 -
>  hw/acpi/memory_hotplug.c         | 1 -
>  hw/alpha/typhoon.c               | 1 -
>  hw/arm/aspeed.c                  | 1 -

It requires the macros declared by:

OBJECT_DECLARE_TYPE(MachineState, MachineClass, MACHINE)

>  hw/arm/omap1.c                   | 1 -
>  hw/arm/omap2.c                   | 1 -
>  hw/arm/strongarm.c               | 1 -
>  hw/arm/virt.c                    | 1 -

Ditto.

>  hw/avr/arduino.c                 | 1 -

Ditto.

>  hw/avr/atmega.c                  | 1 -
>  hw/display/next-fb.c             | 1 -
>  hw/hppa/machine.c                | 1 -

Ditto.

>  hw/i386/acpi-build.c             | 1 -
>  hw/i386/acpi-microvm.c           | 1 -
>  hw/i386/intel_iommu.c            | 1 -
>  hw/i386/pc.c                     | 1 -

Ditto (MACHINE_CLASS macro).

>  hw/i386/x86-iommu.c              | 1 -
>  hw/intc/sifive_plic.c            | 1 -
>  hw/mips/loongson3_virt.c         | 1 -

Ditto.

(skipping the rest).

>  hw/ppc/e500.c                    | 1 -
>  hw/ppc/mac_newworld.c            | 1 -
>  hw/ppc/mac_oldworld.c            | 1 -
>  hw/ppc/pnv.c                     | 1 -
>  hw/ppc/ppc4xx_devs.c             | 1 -
>  hw/ppc/rs6000_mc.c               | 1 -
>  hw/ppc/spapr.c                   | 1 -
>  hw/ppc/spapr_rtas.c              | 1 -
>  hw/remote/iohub.c                | 1 -
>  hw/s390x/s390-virtio-ccw.c       | 2 --
>  hw/tricore/tc27x_soc.c           | 1 -
>  hw/tricore/triboard.c            | 1 -
>  softmmu/vl.c                     | 1 -
>  35 files changed, 36 deletions(-)