[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 1/1] Support monitor chardev hotswap with QMP
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCHv2 1/1] Support monitor chardev hotswap with QMP |
|
Date: |
Sat, 17 Apr 2021 10:05:08 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Li Zhang <zhlcindy@gmail.com> writes:
> On Fri, Apr 16, 2021 at 4:50 PM Markus Armbruster <armbru@redhat.com> wrote:
[...]
>> As I wrote in my review of v1, this function copies from
>> monitor_data_init(), monitor_init_qmp(), and monitor_flush_locked().
>> Feels like a refactoring would be in order. Doing it on top might be
>> easier.
>
> I may misunderstand what you mean. What's the meaning of "doing it on
> top" exactly?
As a separate patch on top of this one. Sorry for the jargon :)
[...]