Re: [PULL 0/7] queue of proposed rc4 fixes

[no-reply]

Patchew URL: 
20210417194205.17057-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20210417194205.17057-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210417194205.17057-1-peter.maydell@linaro.org
Subject: [PULL 0/7] queue of proposed rc4 fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210417194205.17057-1-peter.maydell@linaro.org -> 
patchew/20210417194205.17057-1-peter.maydell@linaro.org
Switched to a new branch 'test'
72e612f accel/tcg: avoid re-translating one-shot instructions
07afad5 target/arm: drop CF_LAST_IO/dc->condjump check
5dc7b9f hw/arm/armsse: Make SSE-300 use Cortex-M55
425d9fe hw/arm/armsse: Give SSE-300 its own Property array
ec5047b include/qemu/osdep.h: Move system includes to top
401fa67 osdep: protect qemu/osdep.h with extern "C"
7cf1c2e osdep: include glib-compat.h before other QEMU headers

=== OUTPUT BEGIN ===
1/7 Checking commit 7cf1c2efd765 (osdep: include glib-compat.h before other 
QEMU headers)
2/7 Checking commit 401fa67e0303 (osdep: protect qemu/osdep.h with extern "C")
WARNING: architecture specific defines should be avoided
#80: FILE: include/qemu/compiler.h:14:
+#ifdef __cplusplus

ERROR: storage class should be at the beginning of the declaration
#81: FILE: include/qemu/compiler.h:15:
+#define QEMU_EXTERN_C extern "C"

ERROR: storage class should be at the beginning of the declaration
#83: FILE: include/qemu/compiler.h:17:
+#define QEMU_EXTERN_C extern

WARNING: architecture specific defines should be avoided
#106: FILE: include/qemu/osdep.h:121:
+#ifdef __cplusplus

WARNING: architecture specific defines should be avoided
#117: FILE: include/qemu/osdep.h:735:
+#ifdef __cplusplus

total: 2 errors, 3 warnings, 56 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit ec5047b58ffc (include/qemu/osdep.h: Move system includes to 
top)
WARNING: architecture specific defines should be avoided
#37: FILE: include/qemu/osdep.h:111:
+#if defined(__linux__) && defined(__sparc__)

WARNING: architecture specific defines should be avoided
#49: FILE: include/qemu/osdep.h:123:
+#ifdef __APPLE__

total: 0 errors, 2 warnings, 50 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/7 Checking commit 425d9fe70cce (hw/arm/armsse: Give SSE-300 its own Property 
array)
5/7 Checking commit 5dc7b9f9db8b (hw/arm/armsse: Make SSE-300 use Cortex-M55)
6/7 Checking commit 07afad503110 (target/arm: drop CF_LAST_IO/dc->condjump 
check)
7/7 Checking commit 72e612ff09f4 (accel/tcg: avoid re-translating one-shot 
instructions)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210417194205.17057-1-peter.maydell@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210417194205.17057-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com