Re: [PATCH 02/26] target/mips: Move IEEE rounding mode array to new source file

[Richard Henderson]

On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote:
> restore_msa_fp_status() is declared inlined in fpu_helper.h,
> and uses the ieee_rm[] array. Therefore any code calling
> restore_msa_fp_status() must have access to this ieee_rm[] array.
>
> kvm_mips_get_fpu_registers(), which is in target/mips/kvm.c,
> calls restore_msa_fp_status.
>
> Except this tiny array, the rest of fpu_helper.c is only useful
> for the TCG accelerator.
>
> To be able to restrict fpu_helper.c to TCG, we need to move the
> ieee_rm[] array to a new source file.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/fpu.c        | 18 ++++++++++++++++++
>   target/mips/fpu_helper.c |  8 --------
>   target/mips/meson.build  |  1 +
>   3 files changed, 19 insertions(+), 8 deletions(-)
>   create mode 100644 target/mips/fpu.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~