[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 23/26] target/mips: Move helper.h -> tcg/helper.h.inc
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 23/26] target/mips: Move helper.h -> tcg/helper.h.inc |
|
Date: |
Sun, 18 Apr 2021 23:20:34 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/18/21 10:34 PM, Richard Henderson wrote:
> On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote:
>> TCG frontend "exec/helper-head.h" expects each target to declare
>> its helpers in 'target/$TARGET/helper.h'. To ease maintenance we
>> rather to have all TCG specific files under our tcg/ sub directory.
>>
>> Move the current 'helper.h' there, and add a one-line 'helper.h'
>> which re-include it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
>> ---
>> target/mips/helper.h | 614 +----------------------------------
>> target/mips/tcg/helper.h.inc | 613 ++++++++++++++++++++++++++++++++++
>> 2 files changed, 614 insertions(+), 613 deletions(-)
>> create mode 100644 target/mips/tcg/helper.h.inc
>
> Eh. Ok, I guess.
>
> If we renamed the file tcg-helper.h{,.inc?} globally, would you still
> want it moved into your tcg/ subdirectory?
Not really... I wanted to have anything TCG related under tcg/,
but I can't find any good reason for it (I was thinking about
finer MAINTAINERS granularity, but this doesn't bring much).
I'll drop this patch, no need to change the other targets.
Thanks for the reviews!
Phil.
- Re: [PATCH 18/26] target/mips: Move Special opcodes to tcg/sysemu/special_helper.c, (continued)
- [PATCH 19/26] target/mips: Move helper_cache() to tcg/sysemu/special_helper.c, Philippe Mathieu-Daudé, 2021/04/18
- [PATCH 20/26] target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c, Philippe Mathieu-Daudé, 2021/04/18
- [PATCH 21/26] target/mips: Move exception management code to exception.c, Philippe Mathieu-Daudé, 2021/04/18
- [PATCH 23/26] target/mips: Move helper.h -> tcg/helper.h.inc, Philippe Mathieu-Daudé, 2021/04/18
- [PATCH 22/26] target/mips: Move CP0 helpers to sysemu/cp0.c, Philippe Mathieu-Daudé, 2021/04/18
- [PATCH 24/26] target/mips: Move TCG source files under tcg/ sub directory, Philippe Mathieu-Daudé, 2021/04/18
- [PATCH 25/26] hw/mips: Restrict non-virtualized machines to TCG, Philippe Mathieu-Daudé, 2021/04/18
- [PATCH 26/26] gitlab-ci: Add KVM mips64el cross-build jobs, Philippe Mathieu-Daudé, 2021/04/18
- Re: [PATCH 00/26] target/mips: Re-org to allow KVM-only builds, no-reply, 2021/04/18