Re: [PATCH v4 08/12] target/hexagon: prepare input for the idef-parser

[Richard Henderson]

On 4/15/21 9:34 AM, Alessandro Di Federico wrote:
> +++ b/target/hexagon/idef-parser/prepare
> @@ -0,0 +1,24 @@
> +#!/bin/bash
> +
> +#
> +# Copyright(c) 2019-2021 rev.ng Srls. All Rights Reserved.
> +#
> +# This library is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU Lesser General Public
> +# License as published by the Free Software Foundation; either
> +# version 2 of the License, or (at your option) any later version.
> +#
> +# This library is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +# Lesser General Public License for more details.
> +#
> +# You should have received a copy of the GNU Lesser General Public
> +# License along with this library; if not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +set -e
> +set -o pipefail
> +
> +# Run the preprocessor and drop comments
> +cpp "$@" | grep -v '^#'

Any reason not to handle '#' lines in the parser?


r~