[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup o
|
From: |
Auger Eric |
|
Subject: |
Re: [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey |
|
Date: |
Mon, 19 Apr 2021 17:03:11 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
Hi Cleber,
On 4/12/21 6:46 AM, Cleber Rosa wrote:
> The public key argument should be a path to a file, and not the
> public key data.
>
> Reported-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/virtiofs_submounts.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/virtiofs_submounts.py
> b/tests/acceptance/virtiofs_submounts.py
> index d77ee356740..21ad7d792e7 100644
> --- a/tests/acceptance/virtiofs_submounts.py
> +++ b/tests/acceptance/virtiofs_submounts.py
> @@ -195,7 +195,7 @@ def setUp(self):
>
> self.run(('ssh-keygen', '-N', '', '-t', 'ed25519', '-f',
> self.ssh_key))
>
> - pubkey = open(self.ssh_key + '.pub').read()
> + pubkey = self.ssh_key + '.pub'
>
> super(VirtiofsSubmountsTest, self).setUp(pubkey)
>
>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
- [PATCH v3 05/11] Acceptance Tests: add port redirection for ssh by default, (continued)
- [PATCH v3 05/11] Acceptance Tests: add port redirection for ssh by default, Cleber Rosa, 2021/04/12
- [PATCH v3 06/11] Acceptance Tests: make username/password configurable, Cleber Rosa, 2021/04/12
- [PATCH v3 07/11] Acceptance Tests: set up SSH connection by default after boot for LinuxTest, Cleber Rosa, 2021/04/12
- [PATCH v3 08/11] tests/acceptance/virtiofs_submounts.py: remove launch_vm(), Cleber Rosa, 2021/04/12
- [PATCH v3 09/11] Acceptance Tests: add basic documentation on LinuxTest base class, Cleber Rosa, 2021/04/12
- [PATCH v3 10/11] Acceptance Tests: introduce CPU hotplug test, Cleber Rosa, 2021/04/12
- [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey, Cleber Rosa, 2021/04/12