[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0] migration: Drop redundant query-migrate result @bloc
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH for-6.0] migration: Drop redundant query-migrate result @blocked |
|
Date: |
Tue, 20 Apr 2021 06:27:12 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> * Peter Maydell (peter.maydell@linaro.org) wrote:
>> On Mon, 19 Apr 2021 at 17:27, Markus Armbruster <armbru@redhat.com> wrote:
>> >
>> > Result @blocked is true when and only when result @blocked-reasons is
>> > present. It's always non-empty when present. @blocked is redundant;
>> > drop.
>> >
>> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> So I'm OK with it in principal and I think the code is OK, so
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
>> "for-6.0" needs to be accompanied by a justification of why it's
>> important to go in the release at this point...
You're right. My bad.
> I guess the argument is that when we hit 6.0 it becomes API and removing
> the 'blocked' becomes a matter of deprecation which is a pain.
Correct.
> Hmm; I agree it's the right change, but I'm not sure I can justify it
> this late in the release.
If we decide taking it out is too late, we should at least deprecate it
in 6.0. I'll post the patch, so you guys can pick the one you like
better.