Re: [PATCH] migration: Deprecate redundant query-migrate result @blocked

[Dr. David Alan Gilbert]

* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Tue, Apr 20, 2021 at 07:19:06AM +0200, Markus Armbruster wrote:
> > Result @blocked is true when and only when result @blocked-reasons is
> > present.  It's always non-empty when present.  @blocked is redundant.
> > It was introduced in commit 3af8554bd0 "migration: Add blocker
> > information", and has not been released.  This gives us a chance to
> > fix the interface with minimal fuss.
> > 
> > Unfortunately, we're already too close to the release to risk dropping
> > it.  Deprecate it instead.
> > 
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> > This is alternative to "[PATCH v2] migration: Drop redundant
> > query-migrate result @blocked".
> > 
> >  qapi/migration.json | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Yes,


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Peter: Do you want to pick that up directly ?

Dave

> 
> 
> Regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK