[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0?] qga: fix guest-get-disks regression
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-6.0?] qga: fix guest-get-disks regression |
|
Date: |
Tue, 20 Apr 2021 15:12:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/20/21 2:58 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 4299ebd96f..75dbaab68e 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions(
> partition = g_new0(GuestDiskInfo, 1);
> partition->name = dev_name;
> partition->partition = true;
> + partition->has_dependencies = true;
> /* Add parent disk as dependent for easier tracking of hierarchy */
> QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev));
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>