qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] target/mips: Remove duplicated check_cp0_enabled() calls


From: Richard Henderson
Subject: Re: [PATCH 1/5] target/mips: Remove duplicated check_cp0_enabled() calls in gen_cp0()
Date: Tue, 20 Apr 2021 18:37:49 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/20/21 12:34 PM, Philippe Mathieu-Daudé wrote:
We already check for CP0 enabled at the beginning of gen_cp0(),
no need to check it again after.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  target/mips/translate.c | 2 --
  1 file changed, 2 deletions(-)

Having noticed the default case for the nanomips decode, I do wonder if having the cp0 check happen before the switch in gen_cp0 is actually correct.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]