[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clan
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang |
|
Date: |
Wed, 21 Apr 2021 18:37:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/21/21 6:33 PM, Thomas Huth wrote:
> When compiling the s390-ccw bios with Clang, the compiler complains:
>
> pc-bios/s390-ccw/bootmap.c:302:9: warning: logical not is only applied
> to the left hand side of this comparison [-Wlogical-not-parentheses]
> if (!mbr->dev_type == DEV_TYPE_ECKD) {
> ^ ~~
>
> The code works (more or less by accident), since dev_type can only be
> 0 or 1, but it's better of course to use the intended != operator here
> instead.
>
> Fixes: 5dc739f343 ("Allow booting in case the first virtio-blk disk is bad")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/bootmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>