[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/8] qapi: static typing conversion, pt4
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 0/8] qapi: static typing conversion, pt4 |
Date: |
Thu, 22 Apr 2021 10:09:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> Hi, this series adds static type hints to the QAPI module.
> This is part four, and focuses on error.py.
>
> Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/290152364
>
> Requirements:
> - Python 3.6+
> - mypy >= 0.770
> - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+)
>
> Every commit should pass with:
> - `isort -c qapi/`
> - `flake8 qapi/`
> - `pylint --rcfile=qapi/pylintrc qapi/`
> - `mypy --config-file=qapi/mypy.ini qapi/`
I doubt PATCH 1 is worth the trouble without an actual concrete
location-less error. However, arguing about it some more would also not
worth the trouble, so:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
and queued. Thanks!
- [PATCH v3 0/8] qapi: static typing conversion, pt4, John Snow, 2021/04/21
- [PATCH v3 1/8] qapi/error: Repurpose QAPIError as an abstract base exception class, John Snow, 2021/04/21
- [PATCH v3 2/8] qapi/error: Use Python3-style super(), John Snow, 2021/04/21
- [PATCH v3 6/8] qapi/error.py: enable pylint checks, John Snow, 2021/04/21
- [PATCH v3 3/8] qapi/error: Make QAPISourceError 'col' parameter optional, John Snow, 2021/04/21
- [PATCH v3 8/8] qapi/error.py: enable mypy checks, John Snow, 2021/04/21
- [PATCH v3 5/8] qapi/error.py: move QAPIParseError to parser.py, John Snow, 2021/04/21
- [PATCH v3 4/8] qapi/error: assert QAPISourceInfo is not None, John Snow, 2021/04/21
- [PATCH v3 7/8] qapi/error: Add type hints, John Snow, 2021/04/21
- Re: [PATCH v3 0/8] qapi: static typing conversion, pt4,
Markus Armbruster <=