qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/7] linux-user: Pass ka_restorer to do_sigaction


From: Alex Bennée
Subject: Re: [PATCH v2 3/7] linux-user: Pass ka_restorer to do_sigaction
Date: Fri, 23 Apr 2021 13:55:29 +0100
User-agent: mu4e 1.5.11; emacs 28.0.50

Richard Henderson <richard.henderson@linaro.org> writes:

> The value of ka_restorer needs to be saved in sigact_table.

It would be nice to add a comment to sigact_table to describe what it
is. This is some of the oldest code in the tree so there seems to be a
fair bit of implicit knowledge is the way things are done.

> At the moment, the attempt to save it in do_syscall is
> improperly clobbering user memory.

Otherwise to my slightly confused eyes it looks pretty sane:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]