Re: [PATCH v1 06/25] docker: Add Hexagon image

[Willian Rampazzo]

On Mon, Apr 19, 2021 at 11:54 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> From: Alessandro Di Federico <ale@rev.ng>
>
> This image is a little special because it takes a long time to build.
> As such most users don't want to be doing that and just pull random
> binaries from the ether as intended by the container gods. This
> involves someone with credentials and a beefy machine running:
>
>   make docker-image-debian-hexagon-cross V=1 NOCACHE=1 J=30
>   docker tag qemu/debian-hexagon-cross 
> registry.gitlab.com/qemu-project/qemu/qemu/debian-hexagon-cross
>   docker push registry.gitlab.com/qemu-project/qemu/qemu/debian-hexagon-cross
>
> With a suitable binary in the "cloud" a normal user will run:
>
>   make docker-image-debian-hexagon-cross
>
> or have it run for them through the dependency mechanism of our
> over-engineered makefiles and get the binary they wanted. There are a
> few wrinkles of course including needing to tweak the final image to
> have the credentials of the user so we can actually do our cross
> compiles.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Alessandro Di Federico <ale@rev.ng>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Cc: Brian Cain <bcain@quicinc.com>
>
> ---
> vAJB:
>   - dropped all r-b/sob due to rewrite
>   - split into a multi-stage dockerfile
>   - make dockerfile standalone
>   - play fugly make games
> v2
>   - update LLVM version per 
> BN7PR02MB4194DF5752EF3BADE858018DB8799@BN7PR02MB4194.namprd02.prod.outlook.com
> ---
>  MAINTAINERS                                   |   2 +
>  tests/docker/Makefile.include                 |  22 +++
>  .../dockerfiles/debian-hexagon-cross.docker   |  44 ++++++
>  .../build-toolchain.sh                        | 141 ++++++++++++++++++
>  4 files changed, 209 insertions(+)
>  create mode 100644 tests/docker/dockerfiles/debian-hexagon-cross.docker
>  create mode 100755 
> tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>