[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 19/24] bsd-user: use qemu_strtol in preference to strtol
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 19/24] bsd-user: use qemu_strtol in preference to strtol |
Date: |
Fri, 23 Apr 2021 23:16:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/23/21 10:39 PM, imp@bsdimp.com wrote:
> From: Warner Losh <imp@bsdimp.com>
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> bsd-user/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index 69e5525607..95fda8c5ae 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -821,7 +821,7 @@ int main(int argc, char **argv)
> }
> } else if (!strcmp(r, "s")) {
> r = argv[optind++];
> - x86_stack_size = strtol(r, (char **)&r, 0);
> + x86_stack_size = qemu_strtol(r, (char **)&r, 0);
> if (x86_stack_size <= 0) {
> usage();
> }
> @@ -853,7 +853,7 @@ int main(int argc, char **argv)
> exit(1);
> }
> } else if (!strcmp(r, "B")) {
> - guest_base = strtol(argv[optind++], NULL, 0);
> + guest_base = qemu_strtol(argv[optind++], NULL, 0);
Missing error check (-EINVAL & -ERANGE).
> have_guest_base = true;
> } else if (!strcmp(r, "drop-ld-preload")) {
> (void) envlist_unsetenv(envlist, "LD_PRELOAD");
>
- Re: [PULL 11/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future, (continued)
[PULL 12/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future, imp, 2021/04/23
[PULL 20/24] bsd-user: introduce host_os.h for bsd-specific code and defaults, imp, 2021/04/23
[PULL 13/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future, imp, 2021/04/23
[PULL 14/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future, imp, 2021/04/23
[PULL 15/24] bsd-user: Fix commentary issues, imp, 2021/04/23
[PULL 19/24] bsd-user: use qemu_strtol in preference to strtol, imp, 2021/04/23
- Re: [PULL 19/24] bsd-user: use qemu_strtol in preference to strtol,
Philippe Mathieu-Daudé <=
[PULL 16/24] bsd-user: Use preferred block comments, imp, 2021/04/23
[PULL 18/24] bsd-user: style changes for {}, imp, 2021/04/23
[PULL 22/24] bsd-user: create target_arch_cpu.h, imp, 2021/04/23
[PULL 23/24] bsd-user: move x86 (i386 and x86_64) cpu_loop to target_arch_cpu.h, imp, 2021/04/23
[PULL 24/24] bsd-user: move sparc cpu_loop into target_arch_cpu.h as target_cpu_loop, imp, 2021/04/23