[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 11/24] bsd-user: style tweak: if 0 -> ifdef notyet for code ne
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 11/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future |
Date: |
Fri, 23 Apr 2021 23:23:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/23/21 10:39 PM, imp@bsdimp.com wrote:
> From: Warner Losh <imp@bsdimp.com>
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> bsd-user/elfload.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
> index 87154283ef..07a00ddbd5 100644
> --- a/bsd-user/elfload.c
> +++ b/bsd-user/elfload.c
> @@ -1270,7 +1270,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct
> target_pt_regs *regs,
> ibcs2_interpreter = 1;
> }
>
> -#if 0
> +#ifdef notyet
Better describe in the cover letter "ignored checkpatch errors" and keep
this unmodified rather than trying to bypass them by dubious code style
IMO. The checkpatch.pl script is here to help us ;)
> printf("Using ELF interpreter %s\n", path(elf_interpreter));
> #endif
[PULL 12/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future, imp, 2021/04/23
[PULL 20/24] bsd-user: introduce host_os.h for bsd-specific code and defaults, imp, 2021/04/23
[PULL 13/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future, imp, 2021/04/23
[PULL 14/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future, imp, 2021/04/23
[PULL 15/24] bsd-user: Fix commentary issues, imp, 2021/04/23