Re: [PULL 10/24] bsd-user: style tweak: use C not C++ comments

[Richard Henderson]

On 4/23/21 1:39 PM, imp@bsdimp.com wrote:
> From: Warner Losh <imp@bsdimp.com>
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
>   bsd-user/qemu.h | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
> index b836b603af..3480db890d 100644
> --- a/bsd-user/qemu.h
> +++ b/bsd-user/qemu.h
> @@ -71,7 +71,7 @@ struct image_info {
>   
>   struct sigqueue {
>       struct sigqueue *next;
> -    //target_siginfo_t info;
> +    /* target_siginfo_t info; */
>   };

Ack.

> @@ -193,9 +193,11 @@ extern int do_strace;
>   /* signal.c */
>   void process_pending_signals(CPUArchState *cpu_env);
>   void signal_init(void);
> -//int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info);
> -//void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info);
> -//void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo);
> +/*
> + * int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info);
> + * void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info);
> + * void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo);
> + */

These should probably be deleted with the #if 0 code that references them.


r~