Re: Ping: [PATCH] Set icon for QEMU binary on Mac OS

[Peter Maydell]

On Fri, 23 Apr 2021 at 22:08, Programmingkid <programmingkidx@gmail.com> wrote:
>
> This patch was submitted in February and I haven't heard anything about it 
> since. Could this be included in the up coming release please?

It's about two weeks late to get into 6.0, I'm afraid.

Cc'ing Paolo for review since it's a meson.build change.

-- PMM

> https://lore.kernel.org/qemu-devel/20210202134410.9274-1-programmingkidx@gmail.com/
>
> Before switching the build system over to Meson, an icon was
> added to the QEMU binary on Mac OS. This patch adds back that
> feature.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
>
> meson.build
>  | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
>
> diff
>  --git a/meson.build b/meson.build
> index f00b7754fd..7f534f4e75 100644
> --- a/meson.build
> +++ b/meson.build
>
> @@ -2183,6 +2183,26 @@ foreach target : target_dirs
>
>                 link_args: link_args,
>                 gui_app: exe['gui'])
>
>
> +# set QEMU's icon on Mac OS
> +if targetos == 'darwin'
> +    newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1',
> +          depends : emulator,
> +          input : emulator,
> +          output : 'new icon for ' + exe_name + ' - 1',
> +          command : ['Rez', '-append',
> +           meson.source_root() + '/pc-bios/qemu.rsrc', '-o',
> +           meson.current_build_dir() / exe['name']],
> +          build_by_default : true)
> +
> +    custom_target('Icon for ' + exe_name + ' - part 2',
> +          depends : newiconpart1,
> +          input : emulator,
> +          output : 'new icon for ' + exe_name + ' - 2',
> +          command : ['SetFile', '-a', 'C',
> +           meson.current_build_dir() / exe['name']],
> +          build_by_default : true)
> +endif
> +
>
>      if exe_sign
>        emulators += {exe['name'] : custom_target(exe['name'],
>                     install: true,
> --
> 2.24.3 (Apple Git-128)