[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 20/25] linux-user/sparc: Clean up setup_frame
From: |
Richard Henderson |
Subject: |
[PATCH v2 20/25] linux-user/sparc: Clean up setup_frame |
Date: |
Sun, 25 Apr 2021 19:53:29 -0700 |
Clean up a goto label with a single use. Remove #if 0.
Remove useless parentheses. Fold constants into __put_user.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/sparc/signal.c | 25 ++++++-------------------
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c
index 4a0578ebf3..f0f614a3af 100644
--- a/linux-user/sparc/signal.c
+++ b/linux-user/sparc/signal.c
@@ -192,14 +192,13 @@ void setup_frame(int sig, struct target_sigaction *ka,
size_t sf_size = sizeof(*sf) + sizeof(struct target_siginfo_fpu);
int i;
- /* 1. Make sure everything is clean */
-
sf_addr = get_sigframe(ka, env, sf_size);
trace_user_setup_frame(env, sf_addr);
sf = lock_user(VERIFY_WRITE, sf_addr, sf_size, 0);
if (!sf) {
- goto sigsegv;
+ force_sigsegv(sig);
+ return;
}
/* 2. Save the current process state */
@@ -228,33 +227,21 @@ void setup_frame(int sig, struct target_sigaction *ka,
/* 4. signal handler */
env->pc = ka->_sa_handler;
- env->npc = (env->pc + 4);
+ env->npc = env->pc + 4;
+
/* 5. return to kernel instructions */
if (ka->ka_restorer) {
env->regwptr[WREG_O7] = ka->ka_restorer;
} else {
- uint32_t val32;
-
env->regwptr[WREG_O7] = sf_addr +
offsetof(struct target_signal_frame, insns) - 2 * 4;
/* mov __NR_sigreturn, %g1 */
- val32 = 0x821020d8;
- __put_user(val32, &sf->insns[0]);
-
+ __put_user(0x821020d8u, &sf->insns[0]);
/* t 0x10 */
- val32 = 0x91d02010;
- __put_user(val32, &sf->insns[1]);
+ __put_user(0x91d02010u, &sf->insns[1]);
}
unlock_user(sf, sf_addr, sf_size);
- return;
-#if 0
-sigill_and_return:
- force_sig(TARGET_SIGILL);
-#endif
-sigsegv:
- unlock_user(sf, sf_addr, sizeof(struct target_signal_frame));
- force_sigsegv(sig);
}
void setup_rt_frame(int sig, struct target_sigaction *ka,
--
2.25.1
- [PATCH v2 06/25] linux-user/sparc: Clean up init_thread, (continued)
- [PATCH v2 06/25] linux-user/sparc: Clean up init_thread, Richard Henderson, 2021/04/25
- [PATCH v2 16/25] linux-user/sparc: Split out save_reg_win, Richard Henderson, 2021/04/25
- [PATCH v2 17/25] linux-user/sparc: Clean up get_sigframe, Richard Henderson, 2021/04/25
- [PATCH v2 05/25] linux-user/sparc: Include TARGET_STACK_BIAS in get_sp_from_cpustate, Richard Henderson, 2021/04/25
- [PATCH v2 10/25] linux-user/sparc: Merge sparc64 termbits.h, Richard Henderson, 2021/04/25
- [PATCH v2 22/25] linux-user/sparc: Add 64-bit support to fpu save/restore, Richard Henderson, 2021/04/25
- [PATCH v2 11/25] linux-user/sparc: Merge sparc64/ into sparc/, Richard Henderson, 2021/04/25
- [PATCH v2 14/25] linux-user/sparc: Fix the stackframe structure, Richard Henderson, 2021/04/25
- [PATCH v2 13/25] linux-user/sparc: Remove target_rt_signal_frame as unused, Richard Henderson, 2021/04/25
- [PATCH v2 15/25] linux-user/sparc: Use target_pt_regs, Richard Henderson, 2021/04/25
- [PATCH v2 20/25] linux-user/sparc: Clean up setup_frame,
Richard Henderson <=
- [PATCH v2 24/25] linux-user/sparc: Implement sparc64 rt signals, Richard Henderson, 2021/04/25
- [PATCH v2 09/25] linux-user/sparc: Merge sparc64 target_structs.h, Richard Henderson, 2021/04/25
- [PATCH v2 25/25] tests/tcg/sparc64: Re-enable linux-test, Richard Henderson, 2021/04/25
- [PATCH v2 12/25] linux-user/sparc: Remove target_sigcontext as unused, Richard Henderson, 2021/04/25
- [PATCH v2 08/25] linux-user/sparc: Merge sparc64 target_elf.h, Richard Henderson, 2021/04/25
- [PATCH v2 18/25] linux-user/sparc: Save and restore fpu in signal frame, Richard Henderson, 2021/04/25
- [PATCH v2 19/25] linux-user/sparc: Add rwin_save to signal frame, Richard Henderson, 2021/04/25
- [PATCH v2 23/25] linux-user/sparc: Implement sparc32 rt signals, Richard Henderson, 2021/04/25
- [PATCH v2 21/25] linux-user/sparc: Minor corrections to do_sigreturn, Richard Henderson, 2021/04/25
- Re: [PATCH v2 00/25] linux-user/sparc: Implement rt signals, Richard Henderson, 2021/04/25