Re: [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo in

qemu-devel

From:	John Snow
Subject:	Re: [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo initializer
Date:	Mon, 26 Apr 2021 13:39:19 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 4/24/21 2:38 AM, Markus Armbruster wrote:

Not mentioned in the commit message: you add a default parameter value.
It's not used; there's just one caller, and it passes a value.
Intentional?

No. Leftover from an earlier version where it was used. It can be madeto always be an explicit parameter now instead.

Current Thread

[Next in Thread]

[PATCH 00/22] qapi: static typing conversion, pt5a, John Snow, 2021/04/21
- [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo initializer, John Snow, 2021/04/21
  - Re: [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo initializer, Markus Armbruster, 2021/04/24
    - Re: [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo initializer, John Snow <=
    - Re: [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo initializer, John Snow, 2021/04/26
    - Re: [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo initializer, Markus Armbruster, 2021/04/27
- [PATCH 01/22] qapi/parser: Don't try to handle file errors, John Snow, 2021/04/21
  - Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors, Markus Armbruster, 2021/04/23
    - Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors, John Snow, 2021/04/23
    - Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors, Markus Armbruster, 2021/04/27
    - Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors, John Snow, 2021/04/27
    - Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors, Markus Armbruster, 2021/04/28
- [PATCH 04/22] qapi/parser: factor parsing routine into method, John Snow, 2021/04/21
- [PATCH 08/22] qapi/parser: Use @staticmethod where appropriate, John Snow, 2021/04/21