qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug 1926246] Re: chrome based apps can not be run under qemu user m


From: Laurent Vivier
Subject: Re: [Bug 1926246] Re: chrome based apps can not be run under qemu user mode
Date: Tue, 27 Apr 2021 11:53:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

Le 27/04/2021 à 10:45, Wind Li a écrit :
> qemu patch:  
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 95d79ddc43..227d9b1b0e 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -8537,7 +8537,7 @@ static abi_long do_syscall1(void *cpu_env, int num, 
> abi_long arg1,
>               * before the execve completes and makes it the other
>               * program's problem.
>               */
> -            ret = get_errno(safe_execve(p, argp, envp));
> +            ret = get_errno(safe_execve(is_proc_myself(p, "exe") ? exec_path 
> : p, argp, envp));
>              unlock_user(p, arg1, 0);
>  
>              goto execve_end;
> 

I think this is the good approach to fix the problem, but exec_path can be not 
set in the case of
AT_EXECFD (binfmt_misc with credential flag) because we use execfd instead. You 
should use
do_openat() to get the file descriptor and execveat() to start the process.

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]