Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string

From:	John Snow
Subject:	Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string
Date:	Tue, 27 Apr 2021 09:58:36 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 4/27/21 8:30 AM, Markus Armbruster wrote:

I assume you need this assertion for mypy.  If yes, let's get the job
done with minimal fuss.  If no, please drop the assertion entirely.

Yep, needed for mypy. You are right that these assertions are forclarifying postconditions of accept() that tie together the value of.tok with the type of .val.


I'll replace the message with a better comment, but we do still need either:

(1) A way to make the return from accept() statically type-safe, or
(2) The assertion.

As with most of the patches after part one of this series, I've optedfor the quicker thing to speed us along to a clean mypy baseline.


(Though I have spent some time prototyping solutions for #1...)

--js

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 08/22] qapi/parser: Use @staticmethod where appropriate, (continued)
- [PATCH 08/22] qapi/parser: Use @staticmethod where appropriate, John Snow, 2021/04/21
- [PATCH 06/22] qapi/parser: assert get_expr returns object in outer loop, John Snow, 2021/04/21
  - Re: [PATCH 06/22] qapi/parser: assert get_expr returns object in outer loop, Markus Armbruster, 2021/04/25
- [PATCH 09/22] qapi: add match_nofail helper, John Snow, 2021/04/21
  - Re: [PATCH 09/22] qapi: add match_nofail helper, Markus Armbruster, 2021/04/25
    - Re: [PATCH 09/22] qapi: add match_nofail helper, John Snow, 2021/04/26
- [PATCH 05/22] qapi/parser: Assert lexer value is a string, John Snow, 2021/04/21
  - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, Markus Armbruster, 2021/04/24
    - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, John Snow, 2021/04/26
    - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, Markus Armbruster, 2021/04/27
    - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, John Snow <=
- [PATCH 07/22] qapi/parser: assert object keys are strings, John Snow, 2021/04/21
  - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, Markus Armbruster, 2021/04/25
    - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, John Snow, 2021/04/26
    - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, Markus Armbruster, 2021/04/27
    - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, John Snow, 2021/04/27
- [PATCH 12/22] qapi/parser: add type hint annotations, John Snow, 2021/04/21
  - Re: [PATCH 12/22] qapi/parser: add type hint annotations, Markus Armbruster, 2021/04/25
    - Re: [PATCH 12/22] qapi/parser: add type hint annotations, John Snow, 2021/04/26
    - Re: [PATCH 12/22] qapi/parser: add type hint annotations, Markus Armbruster, 2021/04/27
    - Re: [PATCH 12/22] qapi/parser: add type hint annotations, John Snow, 2021/04/26

Prev by Date: Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine
Next by Date: Re: [PATCH] spapr: Modify ibm, get-config-addr-info2 to set DEVNUM in PE config address.
Previous by thread: Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string
Next by thread: [PATCH 07/22] qapi/parser: assert object keys are strings
Index(es):
- Date
- Thread