qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/9] ui/vdagent: core infrastructure


From: Marc-André Lureau
Subject: Re: [PATCH v4 4/9] ui/vdagent: core infrastructure
Date: Tue, 27 Apr 2021 19:42:09 +0400

Hi

On Tue, Apr 27, 2021 at 7:04 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
  Hi,

> What about the endianness of the vdagent messages?
>
> It looks like this was never well defined, but that it was settled on LE:
> https://gitlab.freedesktop.org/spice/linux/vd_agent/-/commit/99d9d3583143aef7143ec986cebe2980fdeeb776
>
> It's worth checking or leaving a TODO, I suppose.

Ah, good to know, adding a comment and TODO item for now.

How does things look on the guest side?  Does vdagent work in bigendian
guests?  Which is pretty much s390x these days with even ppc moving to
little endian ...

Based on the commit above, I suppose there were some users on big-endian.

Fwiw, the Spice protocol clearly states that it's LE (unless explicitly stated differently):
https://www.spice-space.org/spice-protocol.html#_common_protocol_definition

reply via email to

[Prev in Thread] Current Thread [Next in Thread]