Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

[Peter Maydell]

On Wed, 28 Apr 2021 at 14:29, Markus Armbruster <armbru@redhat.com> wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
> > These are two separate things:
> >  1) callsites which want to reset some other device, and currently
> >     mostly use eg device_legacy_reset() -- the transition to be done
> >     is to move them to use device_cold_reset(). Similarly, callsites
> >     which currently reset a bus with qbus_reset_all() and should move
> >     to bus_cold_reset().
> >  2) devices which implement reset and currently do so with a
> >     single reset method -- the transition to be done is to have
> >     them implement however many phases of 3-phase reset they need
> >
> > (1) is easier than (2) because there are many fewer callsites
> > trying to manually reset devices or buses than there are
> > devices that implement reset.
>
> My ignorance on "these are two separate things" is further evidence that
> working examples are needed.  Damien?  Peter?  Pretty-please?

On (1), see the other email thread we had a day or so ago. The
conversion is mostly going to be "replace the device_legacy_reset
call with device_cold_reset" but the tricky bit is checking that
the device being reset doesn't have any qbuses attached, or if
it does that we want them to be reset. On (2), there are a few
examples of converted devices in the tree.

thanks
-- PMM