[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtio
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd |
|
Date: |
Wed, 28 Apr 2021 21:34:18 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/28/21 9:24 PM, Richard Henderson wrote:
> On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote:
>> Are you suggesting to remove the 'if have_block' check? This makes build
>> a the files pointlessly for user-mode-only builds...
>
> But since the objects are not included in the binary, I don't care.
>
> The build system is already too complex, and building a couple of extra
> small files makes only milliseconds of difference.
Maybe for libqemuutil.a (this does make a difference with the Python
QAPI generated files - another series).
I'll wait if we get to a consensus about what exactly is virtiofsd,
then revisit this series.
Thanks!
Phil.
- Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled, (continued)
[PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd, Philippe Mathieu-Daudé, 2021/04/28
Re: [PATCH 0/2] virtiofsd: Meson build fixes, Peter Maydell, 2021/04/28