Re: [PATCH v1] tests/migration: introduce multifd into guestperf

[Daniel P . Berrangé]

On Sat, Mar 20, 2021 at 01:04:56AM +0800, huangy81@chinatelecom.cn wrote:
> From: Hyman <huangy81@chinatelecom.cn>
> 
> Guestperf tool does not cover the multifd-enabled migration
> currently, it is worth supporting so that developers can
> analysis the migration performance with all kinds of
> migration.
> 
> To request that multifd is enabled, with 4 channels:
> $ ./tests/migration/guestperf.py \
>     --multifd --multifd-channels 4 --output output.json
> 
> To run the entire standardized set of multifd-enabled
> comparisons, with unix migration:
> $ ./tests/migration/guestperf-batch.py \
>     --dst-host localhost --transport unix \
>     --filter compr-multifd* --output outputdir
> 
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
>  tests/migration/guestperf/comparison.py | 14 ++++++++++++++
>  tests/migration/guestperf/engine.py     | 16 ++++++++++++++++
>  tests/migration/guestperf/scenario.py   | 12 ++++++++++--
>  tests/migration/guestperf/shell.py      | 10 +++++++++-
>  4 files changed, 49 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

I'll queue it, sorry for the delay in responding to this.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|