[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 1/7] tests/acceptance: Automatic set -cpu to the test vm
From: |
Wainer dos Santos Moschetta |
Subject: |
[PATCH v3 1/7] tests/acceptance: Automatic set -cpu to the test vm |
Date: |
Fri, 30 Apr 2021 10:34:08 -0300 |
This introduces a new feature to the functional tests: automatic setting of
the '-cpu VALUE' option to the created vm if the test is tagged with
'cpu:VALUE'. The 'cpu' property is made available to the test object as well.
For example, for a simple test as:
def test(self):
"""
:avocado: tags=cpu:host
"""
self.assertEqual(self.cpu, "host")
self.vm.launch()
The resulting QEMU evocation will be like:
qemu-system-x86_64 -display none -vga none \
-chardev
socket,id=mon,path=/var/tmp/avo_qemu_sock_pdgzbgd_/qemu-1135557-monitor.sock \
-mon chardev=mon,mode=control -cpu host
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
docs/devel/testing.rst | 17 +++++++++++++++++
tests/acceptance/avocado_qemu/__init__.py | 5 +++++
2 files changed, 22 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 1da4c4e4c4..e139a618f5 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -878,6 +878,17 @@ name. If one is not given explicitly, it will either be
set to
``None``, or, if the test is tagged with one (and only one)
``:avocado: tags=arch:VALUE`` tag, it will be set to ``VALUE``.
+cpu
+~~~
+
+The cpu model that will be set to all QEMUMachine instances created
+by the test.
+
+The ``cpu`` attribute will be set to the test parameter of the same
+name. If one is not given explicitly, it will either be set to
+``None ``, or, if the test is tagged with one (and only one)
+``:avocado: tags=cpu:VALUE`` tag, it will be set to ``VALUE``.
+
machine
~~~~~~~
@@ -924,6 +935,12 @@ architecture of a kernel or disk image to boot a VM with.
This parameter has a direct relation with the ``arch`` attribute. If
not given, it will default to None.
+cpu
+~~~
+
+The cpu model that will be set to all QEMUMachine instances created
+by the test.
+
machine
~~~~~~~
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index 83b1741ec8..7f8e703757 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -206,6 +206,9 @@ def setUp(self):
self.arch = self.params.get('arch',
default=self._get_unique_tag_val('arch'))
+ self.cpu = self.params.get('cpu',
+ default=self._get_unique_tag_val('cpu'))
+
self.machine = self.params.get('machine',
default=self._get_unique_tag_val('machine'))
@@ -231,6 +234,8 @@ def get_vm(self, *args, name=None):
name = str(uuid.uuid4())
if self._vms.get(name) is None:
self._vms[name] = self._new_vm(*args)
+ if self.cpu is not None:
+ self._vms[name].add_args('-cpu', self.cpu)
if self.machine is not None:
self._vms[name].set_machine(self.machine)
return self._vms[name]
--
2.29.2
- [PATCH v3 0/7] tests/acceptance: Handle tests with "cpu" tag, Wainer dos Santos Moschetta, 2021/04/30
- [PATCH v3 2/7] tests/acceptance: Fix mismatch on cpu tagged tests, Wainer dos Santos Moschetta, 2021/04/30
- [PATCH v3 3/7] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests, Wainer dos Santos Moschetta, 2021/04/30
- [PATCH v3 5/7] python/qemu: Add args property to the QEMUMachine class, Wainer dos Santos Moschetta, 2021/04/30
- [PATCH v3 4/7] tests/acceptance: Tagging tests with "cpu:VALUE", Wainer dos Santos Moschetta, 2021/04/30
- [PATCH v3 6/7] tests/acceptance: Add set_vm_arg() to the Test class, Wainer dos Santos Moschetta, 2021/04/30
- [PATCH v3 1/7] tests/acceptance: Automatic set -cpu to the test vm,
Wainer dos Santos Moschetta <=
- [PATCH v3 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests, Wainer dos Santos Moschetta, 2021/04/30