Re: [PATCH v3] Set the correct env->fpip for x86 float instructions

[no-reply]

Patchew URL: 
20210430223701.176696-1-ziqiaokong@gmail.com/">https://patchew.org/QEMU/20210430223701.176696-1-ziqiaokong@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210430223701.176696-1-ziqiaokong@gmail.com
Subject: [PATCH v3] Set the correct env->fpip for x86 float instructions

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210430223701.176696-1-ziqiaokong@gmail.com -> 
patchew/20210430223701.176696-1-ziqiaokong@gmail.com
Switched to a new branch 'test'
4929529 Set the correct env->fpip for x86 float instructions

=== OUTPUT BEGIN ===
ERROR: space required before the open parenthesis '('
#950: FILE: target/i386/tcg/translate.c:6224:
+                    switch(rm) {

ERROR: trailing whitespace
#1145: FILE: target/i386/tcg/translate.c:6375:
+                tcg_gen_st_tl(s->T0, cpu_env, offsetof(CPUX86State, fpip));    
            $

ERROR: line over 90 characters
#1145: FILE: target/i386/tcg/translate.c:6375:
+                tcg_gen_st_tl(s->T0, cpu_env, offsetof(CPUX86State, fpip));    
            

WARNING: line over 80 characters
#1153: FILE: target/i386/tcg/translate.c:6383:
+                                 offsetof(CPUX86State, 
segs[last_seg].selector));

total: 3 errors, 1 warnings, 1112 lines checked

Commit 49295295beb7 (Set the correct env->fpip for x86 float instructions) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210430223701.176696-1-ziqiaokong@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210430223701.176696-1-ziqiaokong@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com