Re: [PATCH v2 00/36] linux-user: Signal trampolines and vdsos

[Peter Maydell]

On Wed, 7 Jul 2021 at 00:51, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Supercedes: <20210619034329.532318-1-richard.henderson@linaro.org>
> ("[PATCH 00/12] linux-user: Load a vdso for x86_64 and hppa")
>
> Supercedes: <20210618192951.125651-1-richard.henderson@linaro.org>
> ("[PATCH v2 00/23] linux-user: Move signal trampolines to new page")
>
> Changes for v2:
>   * Add vdsos for aarch64, arm, i386, riscv.
>   * Drop setup_sigtramp for any target with a vdso.
>   * Drop arm v1 signal support.
>   * Simplify ppc encode_trampoline.

I'm not planning to review this series, but a general comment:
I'm not really enthusiastic about the "vdso binaries checked into
git and the build mechanism is a random makefile that has to be
run by hand in the right environment" setup (and distros that
like to build everything from source probably won't be keen
either). At a minimum the handling of the cross-environment
stuff should be more automated and reproducible like 'make check-tcg'.
It would be useful also to get input from the Debian folks on
how they'd want to see the build-from-source requirements/setup
working...

-- PMM