Re: [PATCH for-6.2 v3 05/12] job: @force parameter for job_cancel_sync{,_all}()

[Hanna Reitz]

On 01.09.21 13:04, Vladimir Sementsov-Ogievskiy wrote:
> 06.08.2021 12:38, Max Reitz wrote:
> > @@ -726,7 +726,7 @@ static void replication_stop(ReplicationState 
> > *rs, bool failover, Error **errp)
> >            * disk, secondary disk in backup_job_completed().
> >            */
> >           if (s->backup_job) {
> > -            job_cancel_sync(&s->backup_job->job);
> > +            job_cancel_sync(&s->backup_job->job, false);
>
> That's not quite correct, as backup is always force cancelled..

Good point.  I think functionally it shouldn’t make a difference, right? 
– but it’s better to be explicit about it and only use force=false where 
it actually makes a difference.

Hanna