qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/4] iotests/297: Cover tests/


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v3 0/4] iotests/297: Cover tests/
Date: Wed, 1 Sep 2021 16:34:11 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

A kind of ping:)

Seems that never landed into master?

14.05.2021 18:43, Max Reitz wrote:
v1: https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg01471.html
v2: https://lists.nongnu.org/archive/html/qemu-block/2021-05/msg00492.html


Hi,

When reviewing Vladimir’s new addition to tests/, I noticed that 297 so
far does not cover named tests.  That isn’t so good.

This series makes it cover them, and because tests/ is rather sparse at
this point, I decided to also fix up the two tests in there that don’t
pass pylint’s scrutiny yet.  I think it would be nice if we could keep
all of tests/ clean.


v3:
- Fixed patch 3: Turns out replacing `lambda self: mc(self)` by just
   `mc` (as pylint suggests) breaks the test.  So leave it as it is and
   instead disable the warning locally.


git-backport-diff against v3:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/4:[----] [--] 'iotests/297: Drop 169 and 199 from the skip list'
002/4:[----] [--] 'migrate-bitmaps-postcopy-test: Fix pylint warnings'
003/4:[0005] [FC] 'migrate-bitmaps-test: Fix pylint warnings'
004/4:[----] [--] 'iotests/297: Cover tests/'


Max Reitz (4):
   iotests/297: Drop 169 and 199 from the skip list
   migrate-bitmaps-postcopy-test: Fix pylint warnings
   migrate-bitmaps-test: Fix pylint warnings
   iotests/297: Cover tests/

  tests/qemu-iotests/297                        |  7 ++--
  .../tests/migrate-bitmaps-postcopy-test       | 13 +++---
  tests/qemu-iotests/tests/migrate-bitmaps-test | 41 +++++++++++--------
  3 files changed, 34 insertions(+), 27 deletions(-)



--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]