Re: [PATCH v2 0/1] hw/arm/aspeed: Allow machine to set UART default

[Philippe Mathieu-Daudé]

On 9/1/21 5:36 PM, pdel@fb.com wrote:
> From: Peter Delevoryas <pdel@fb.com>
> 
> v1: https://lore.kernel.org/qemu-devel/20210831233140.2659116-1-pdel@fb.com/
> v2:
> - Replaced AspeedMachineClass "serial_hd0" with "uart_default"
> - Removed "qdev_get_machine()" usage
> - Removed unnecessary aspeed.h (machine class) includes in device files
> - Added "uint32_t uart_default" to AspeedSoCState
> - Added "uart-default" uint32 property to AspeedSoCState
> - Set "uart-default" just before qdev_realize()
> 
> NOTE: Still not totally sure I did this right, especially because I only
> initialized the properties in the aspeed_soc.c file (2400 + 2500), but
> not aspeed_ast2600.c (2600), but I guess that's because
> aspeed_soc_class_init is common to all the SoC's.
> 
> Peter Delevoryas (1):
>   hw/arm/aspeed: Allow machine to set UART default
> 
>  hw/arm/aspeed.c             | 3 +++
>  hw/arm/aspeed_ast2600.c     | 8 ++++----
>  hw/arm/aspeed_soc.c         | 9 ++++++---
>  include/hw/arm/aspeed.h     | 1 +
>  include/hw/arm/aspeed_soc.h | 1 +
>  5 files changed, 15 insertions(+), 7 deletions(-)
> 
> Interdiff against v1:

[...]

Not needed because QEMU uses patchew :)

20210901153615.2746885-1-pdel@fb.com/">https://patchew.org/QEMU/20210831233140.2659116-1-pdel@fb.com/diff/20210901153615.2746885-1-pdel@fb.com/