[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/11] util/vfio-helpers: Use error_setg in qemu_vfio_find
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v3 08/11] util/vfio-helpers: Use error_setg in qemu_vfio_find_[fixed/temp]_iova |
Date: |
Thu, 2 Sep 2021 09:15:17 +0200 |
On Sep 2 09:00, Philippe Mathieu-Daudé wrote:
> Both qemu_vfio_find_fixed_iova() and qemu_vfio_find_temp_iova()
> return an errno which is unused (or overwritten). Have them propagate
> eventual errors to callers, returning a boolean (which is what the
> Error API recommends, see commit e3fe3988d78 "error: Document Error
> API usage rules" for rationale).
>
> Suggested-by: Klaus Jensen <k.jensen@samsung.com>
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
The switch to bool LGTM.
Reviewed and Acked :)
signature.asc
Description: PGP signature
- [PATCH v3 00/11] block/nvme: Rework error reporting, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 02/11] util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 01/11] block/nvme: Use safer trace format string, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 03/11] util/vfio-helpers: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 04/11] util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 05/11] block/nvme: Have nvme_create_queue_pair() report errors consistently, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 07/11] util/vfio-helpers: Extract qemu_vfio_water_mark_reached(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 06/11] util/vfio-helpers: Pass Error handle to qemu_vfio_dma_map(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 08/11] util/vfio-helpers: Use error_setg in qemu_vfio_find_[fixed/temp]_iova, Philippe Mathieu-Daudé, 2021/09/02
- Re: [PATCH v3 08/11] util/vfio-helpers: Use error_setg in qemu_vfio_find_[fixed/temp]_iova,
Klaus Jensen <=
- [PATCH v3 09/11] util/vfio-helpers: Simplify qemu_vfio_dma_map() returning directly, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 10/11] util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Error, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v3 11/11] block/nvme: Only report VFIO error on failed retry, Philippe Mathieu-Daudé, 2021/09/02
- Re: [PATCH v3 00/11] block/nvme: Rework error reporting, Stefan Hajnoczi, 2021/09/02