[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 30/35] acpi: arm/virt: build_spcr: fix invalid cast
From: |
Eric Auger |
Subject: |
Re: [PATCH v2 30/35] acpi: arm/virt: build_spcr: fix invalid cast |
Date: |
Thu, 2 Sep 2021 17:51:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 7/8/21 5:46 PM, Igor Mammedov wrote:
> implicit cast to structure uint8_t member didn't raise error when
> assigning value from incorrect enum, but when using build_append_gas()
> (next patch) it will error out with (clang):
> implicit conversion from enumeration type 'AmlRegionSpace'
> to different enumeration type 'AmlAddressSpace'
> fix cast error by using correct AML_AS_SYSTEM_MEMORY enum
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
> ---
> CC: drjones@redhat.com
> CC: peter.maydell@linaro.org
> CC: shannon.zhaosl@gmail.com
> CC: qemu-arm@nongnu.org
> ---
> hw/arm/virt-acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index b88ea4b70a..a07540affb 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -361,7 +361,7 @@ build_spcr(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
>
> spcr->interface_type = 0x3; /* ARM PL011 UART */
>
> - spcr->base_address.space_id = AML_SYSTEM_MEMORY;
> + spcr->base_address.space_id = AML_AS_SYSTEM_MEMORY;
> spcr->base_address.bit_width = 8;
> spcr->base_address.bit_offset = 0;
> spcr->base_address.access_width = 1;
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 30/35] acpi: arm/virt: build_spcr: fix invalid cast,
Eric Auger <=