[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] memory: Have 'info mtree' remove duplicated Address S
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 2/2] memory: Have 'info mtree' remove duplicated Address Space information |
|
Date: |
Fri, 3 Sep 2021 10:40:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 9/2/21 11:55 PM, Peter Xu wrote:
> Hi, Phil,
>
> On Thu, Sep 02, 2021 at 08:26:04AM +0200, Philippe Mathieu-Daudé wrote:
>> address-space shared 4 times:
>
> I commented on the format of the output, I saw that it's switched back to the
> v1. Any reason?
The code uses the format you asked, I simply forgot to update the
commit description :/ Sorry, I'll respin.
>
> Although I still think what I proposed looks better, I don't have a strong
> "no"
> to this either. Just want to know the motivations.
>
> E.g., for a script parsing this output, it can easily skip and identify
> duplications when scanned "address-space:" following another "address-space:".
> Now it needs to understand two layouts, and that "N times" looks superfluous.