[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/22] plugins/hotblocks: Added correct boolean argument parsing
From: |
Alex Bennée |
Subject: |
[PULL 12/22] plugins/hotblocks: Added correct boolean argument parsing |
Date: |
Fri, 3 Sep 2021 10:03:29 +0100 |
From: Mahmoud Mandour <ma.mandourr@gmail.com>
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210730135817.17816-5-ma.mandourr@gmail.com>
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 4b08340143..062200a7a4 100644
--- a/contrib/plugins/hotblocks.c
+++ b/contrib/plugins/hotblocks.c
@@ -133,8 +133,18 @@ QEMU_PLUGIN_EXPORT
int qemu_plugin_install(qemu_plugin_id_t id, const qemu_info_t *info,
int argc, char **argv)
{
- if (argc && strcmp(argv[0], "inline") == 0) {
- do_inline = true;
+ for (int i = 0; i < argc; i++) {
+ char *opt = argv[i];
+ g_autofree char **tokens = g_strsplit(opt, "=", 2);
+ if (g_strcmp0(tokens[0], "inline") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_inline)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", opt);
+ return -1;
+ }
+ } else {
+ fprintf(stderr, "option parsing failed: %s\n", opt);
+ return -1;
+ }
}
plugin_init();
--
2.30.2
- [PULL 01/22] plugins/execlog: removed unintended "s" at the end of log lines., (continued)
- [PULL 01/22] plugins/execlog: removed unintended "s" at the end of log lines., Alex Bennée, 2021/09/03
- [PULL 02/22] gitlab-ci: Merge "build-disabled" with "build-without-default-features", Alex Bennée, 2021/09/03
- [PULL 11/22] plugins/hotpages: introduce sortby arg and parsed bool args correctly, Alex Bennée, 2021/09/03
- [PULL 04/22] gitlab-ci: Fix ..._RUNNER_AVAILABLE variables and document them, Alex Bennée, 2021/09/03
- [PULL 09/22] plugins: allow plugin arguments to be passed directly, Alex Bennée, 2021/09/03
- [PULL 07/22] plugins: sort exported symbol list, Alex Bennée, 2021/09/03
- [PULL 05/22] plugins: do not limit exported symbols if modules are active, Alex Bennée, 2021/09/03
- [PULL 08/22] docs/devel/tcg-plugins: added cores arg to cache plugin, Alex Bennée, 2021/09/03
- [PULL 06/22] plugins/cache: supported multicore cache modelling, Alex Bennée, 2021/09/03
- [PULL 15/22] plugins/howvec: adapting to the new argument passing scheme, Alex Bennée, 2021/09/03
- [PULL 12/22] plugins/hotblocks: Added correct boolean argument parsing,
Alex Bennée <=
- [PULL 19/22] tests/plugins/mem: introduce "track" arg and make args not positional, Alex Bennée, 2021/09/03
- [PULL 17/22] tests/plugins/bb: adapt to the new arg passing scheme, Alex Bennée, 2021/09/03
- [PULL 20/22] tests/plugins/syscalls: adhere to new arg-passing scheme, Alex Bennée, 2021/09/03
- [PULL 22/22] docs/devel: be consistent about example plugin names, Alex Bennée, 2021/09/03
- [PULL 10/22] plugins/api: added a boolean parsing plugin api, Alex Bennée, 2021/09/03
- [PULL 14/22] plugins/hwprofile: adapt to the new plugin arguments scheme, Alex Bennée, 2021/09/03
- [PULL 13/22] plugins/lockstep: make socket path not positional & parse bool arg, Alex Bennée, 2021/09/03
- [PULL 18/22] tests/plugins/insn: made arg inline not positional and parse it as bool, Alex Bennée, 2021/09/03
- [PULL 16/22] docs/tcg-plugins: new passing parameters scheme for cache docs, Alex Bennée, 2021/09/03
- [PULL 21/22] docs/deprecated: deprecate passing plugin args through `arg=`, Alex Bennée, 2021/09/03