[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 02/21] vhost-vdpa: correctly return err in vhost_vdpa_set_back
From: |
Jason Wang |
Subject: |
[PATCH V2 02/21] vhost-vdpa: correctly return err in vhost_vdpa_set_backend_cap() |
Date: |
Fri, 3 Sep 2021 17:10:12 +0800 |
We should return error code instead of zero, otherwise there's no way
for the caller to detect the failure.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/virtio/vhost-vdpa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 4fa414feea..579f515e65 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -432,13 +432,13 @@ static int vhost_vdpa_set_backend_cap(struct vhost_dev
*dev)
int r;
if (vhost_vdpa_call(dev, VHOST_GET_BACKEND_FEATURES, &features)) {
- return 0;
+ return -EFAULT;
}
features &= f;
r = vhost_vdpa_call(dev, VHOST_SET_BACKEND_FEATURES, &features);
if (r) {
- return 0;
+ return -EFAULT;
}
dev->backend_cap = features;
--
2.25.1
- [PATCH V2 00/21] vhost-vDPA multiqueue, Jason Wang, 2021/09/03
- [PATCH V2 01/21] vhost-vdpa: remove unused variable "acked_features", Jason Wang, 2021/09/03
- [PATCH V2 02/21] vhost-vdpa: correctly return err in vhost_vdpa_set_backend_cap(),
Jason Wang <=
- [PATCH V2 03/21] vhost_net: remove the meaningless assignment in vhost_net_start_one(), Jason Wang, 2021/09/03
- [PATCH V2 04/21] vhost: use unsigned int for nvqs, Jason Wang, 2021/09/03
- [PATCH V2 05/21] vhost_net: do not assume nvqs is always 2, Jason Wang, 2021/09/03
- [PATCH V2 06/21] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add(), Jason Wang, 2021/09/03
- [PATCH V2 07/21] vhost-vdpa: don't cleanup twice in vhost_vdpa_add(), Jason Wang, 2021/09/03
- [PATCH V2 08/21] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add(), Jason Wang, 2021/09/03
- [PATCH V2 09/21] vhost-vdpa: tweak the error label in vhost_vdpa_add(), Jason Wang, 2021/09/03
- [PATCH V2 10/21] vhost-vdpa: fix the wrong assertion in vhost_vdpa_init(), Jason Wang, 2021/09/03
- [PATCH V2 11/21] vhost-vdpa: remove the unncessary queue_index assignment, Jason Wang, 2021/09/03
- [PATCH V2 12/21] vhost-vdpa: open device fd in net_init_vhost_vdpa(), Jason Wang, 2021/09/03