Re: [PATCH v2] fdc: check null block pointer before r/w data transfer

[Salvatore Bonaccorso]

On Tue, Sep 22, 2020 at 06:42:22PM +0800, Li Qiang wrote:
> P J P <ppandit@redhat.com> 于2020年9月22日周二 下午5:29写道：
> >
> > From: Prasad J Pandit <pjp@fedoraproject.org>
> >
> > While transferring data via fdctrl_read/write_data() routines,
> > check that current drive does not have a null block pointer.
> > Avoid null pointer dereference.
> >
> >  -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Ffdc_nullptr1
> >     ==1658854==Hint: address points to the zero page.
> >     #0 blk_inc_in_flight block/block-backend.c:1327
> >     #1 blk_prw block/block-backend.c:1299
> >     #2 blk_pwrite block/block-backend.c:1464
> >     #3 fdctrl_write_data hw/block/fdc.c:2418
> >     #4 fdctrl_write hw/block/fdc.c:962
> >     #5 portio_write ioport.c:205
> >     #6 memory_region_write_accessor memory.c:483
> >     #7 access_with_adjusted_size memory.c:544
> >     #8 memory_region_dispatch_write memory.c:1476
> >
> > Reported-by: Ruhr-University <bugs-syssec@rub.de>
> > Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> 
> Reviewed-by: Li Qiang <liq3ea@gmail.com>

Did this one just felt through the cracks, or was it not further
considered?

Regards,
Salvatore