[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/5] meson_options.txt: Switch the default value for the v
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 2/5] meson_options.txt: Switch the default value for the vnc option to 'auto' |
Date: |
Fri, 3 Sep 2021 12:18:07 -0500 |
User-agent: |
NeoMutt/20210205-739-420e15 |
On Fri, Sep 03, 2021 at 10:13:55AM +0200, Thomas Huth wrote:
> There is no reason why VNC should always be enabled and not be set to
> the default value. We already switched the setting in the "configure"
> script in commit 3a6a1256d4 ("configure: Allow vnc to get disabled with
> --without-default-features"), so let's do that in meson_options.txt now,
> too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson_options.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/meson_options.txt b/meson_options.txt
> index a9a9b8f4c6..2c89e79e8b 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -120,7 +120,7 @@ option('usb_redir', type : 'feature', value : 'auto',
> description: 'libusbredir support')
> option('virglrenderer', type : 'feature', value : 'auto',
> description: 'virgl rendering support')
> -option('vnc', type : 'feature', value : 'enabled',
> +option('vnc', type : 'feature', value : 'auto',
> description: 'VNC server')
> option('vnc_jpeg', type : 'feature', value : 'auto',
> description: 'JPEG lossy compression for VNC server')
> --
> 2.27.0
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 0/5] Use meson_options.txt in the configure script, Thomas Huth, 2021/09/03
- [PATCH v2 2/5] meson_options.txt: Switch the default value for the vnc option to 'auto', Thomas Huth, 2021/09/03
- [PATCH v2 1/5] configure: Add the possibility to read options from meson_options.txt, Thomas Huth, 2021/09/03
- [PATCH v2 4/5] configure: Get help text from meson_options.txt, Thomas Huth, 2021/09/03
- [PATCH v2 3/5] configure: Remove options that can be handled via meson_options.txt instead, Thomas Huth, 2021/09/03
- [PATCH v2 5/5] meson_options.txt: Document that "configure" reads this file, too, Thomas Huth, 2021/09/03