qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] iotests/check: move long options to double dash


From: Eric Blake
Subject: Re: [PATCH v2] iotests/check: move long options to double dash
Date: Fri, 3 Sep 2021 12:29:16 -0500
User-agent: NeoMutt/20210205-739-420e15

On Fri, Sep 03, 2021 at 03:00:39PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> So, the change:
> 
>   -makecheck -> --makecheck
>   -gdb       -> --gdb
>   -valgrind  -> --valgrind
>   -misalign  -> --misalign
>   -nocache   -> --nocache
>   -qcow2 (and other formats) -> --qcow2
>   -file (and other protocols) -> --file
> 
> Motivation:
> 
> 1. check scripts uses ArgumentParser to parse options, which supports
>    combining of short options. So using one dash for long options is a
>    bit ambiguous.
> 
> 2. Several long options are already have double dash:
>   --dry-run, --color, --groups, --exclude-groups, --start-from
> 
> 3. -misalign is used to add --misalign option (two dashes) to qemu-io
> 
> 4. qemu-io and qemu-nbd has --nocache option (two dashes)
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]