[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/19] libdecnumber: Introduce decNumberIntegralToInt128
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 11/19] libdecnumber: Introduce decNumberIntegralToInt128 |
|
Date: |
Fri, 3 Sep 2021 23:14:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 8/31/21 6:39 PM, Luis Pires wrote:
+ if (decNumberIsSpecial(dn) || (dn->exponent < 0) ||
+ (dn->digits + dn->exponent > 39)) {
+ goto Invalid;
+ } else {
No need for the goto and the else. Pick one. Probably the goto, since you need it anyway
for the other overflow cases.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 11/19] libdecnumber: Introduce decNumberIntegralToInt128,
Richard Henderson <=