qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/3] memory: Have 'info mtree' remove duplicated Address S


From: Richard Henderson
Subject: Re: [PATCH v4 3/3] memory: Have 'info mtree' remove duplicated Address Space information
Date: Sat, 4 Sep 2021 11:27:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/1/21 6:19 PM, Philippe Mathieu-Daudé wrote:
@@ -3282,6 +3282,59 @@ static void mtree_info_flatview(bool dispatch_tree, bool 
owner)
      /* Free */
      g_hash_table_foreach_remove(views, mtree_info_flatview_free, 0);
      g_hash_table_unref(views);
+
+    return;
+}

Bogus.

+    return g_strcmp0(as_a->name, as_b->name);
+}
+static void mtree_print_as_name(gpointer data, gpointer user_data)

Mind the missing vertical whitespace.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]