Re: [PATCH v4 14/21] target/loongarch: Add floating point load/store instruction translation

[Richard Henderson]

On 9/2/21 2:41 PM, Song Gao wrote:
> This patch implement floating point load/store instruction translation.
>
> This includes:
> - FLD.{S/D}, FST.{S/D}
> - FLDX.{S/D}, FSTX.{S/D}
> - FLD{GT/LE}.{S/D}, FST{GT/LE}.{S/D}
>
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> Signed-off-by: XiaoJuan Yang<yangxiaojuan@loongson.cn>
> ---
>   target/loongarch/insn_trans/trans_fmemory.c | 143 ++++++++++++++++++++++++++++
>   target/loongarch/insns.decode               |  24 +++++
>   target/loongarch/translate.c                |   1 +
>   3 files changed, 168 insertions(+)
>   create mode 100644 target/loongarch/insn_trans/trans_fmemory.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I wonder if you want to add nanboxing for loads, since you did it for the arithmetic?  But 
certainly this is correct per spec as-is.


r~