qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 03/13] s390x/tcg: convert real to absolute address for RRB


From: Thomas Huth
Subject: Re: [PATCH v3 03/13] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE
Date: Mon, 6 Sep 2021 12:01:25 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0

On 03/09/2021 17.55, David Hildenbrand wrote:
For RRBE, SSKE, and ISKE, we're dealing with real addresses, so we have to
convert to an absolute address first.

In the future, when adding EDAT1 support, we'll have to pay attention to
SSKE handling, as we'll be dealing with absolute addresses when the
multiple-block control is one.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
  target/s390x/tcg/mem_helper.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c
index 3c0820dd74..dd506d8d17 100644
--- a/target/s390x/tcg/mem_helper.c
+++ b/target/s390x/tcg/mem_helper.c
@@ -2177,6 +2177,7 @@ uint64_t HELPER(iske)(CPUS390XState *env, uint64_t r2)
      uint64_t addr = wrap_address(env, r2);
      uint8_t key;
+ addr = mmu_real2abs(env, addr);
      if (addr > ms->ram_size) {
          return 0;
      }
@@ -2201,6 +2202,7 @@ void HELPER(sske)(CPUS390XState *env, uint64_t r1, 
uint64_t r2)
      uint64_t addr = wrap_address(env, r2);
      uint8_t key;
+ addr = mmu_real2abs(env, addr);
      if (addr > ms->ram_size) {
          return;
      }
@@ -2228,6 +2230,7 @@ uint32_t HELPER(rrbe)(CPUS390XState *env, uint64_t r2)
      static S390SKeysClass *skeyclass;
      uint8_t re, key;
+ addr = mmu_real2abs(env, addr);
      if (addr > ms->ram_size) {
          return 0;
      }


Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]