[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] hw/arm/virt_acpi_build: Generate DBG2 table
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v2 0/3] hw/arm/virt_acpi_build: Generate DBG2 table |
Date: |
Tue, 7 Sep 2021 09:02:25 +0200 |
On Mon, 6 Sep 2021 14:31:36 +0200
Eric Auger <eric.auger@redhat.com> wrote:
> This series generates the ACPI DBG2 table along with machvirt.
> It applies on top of Igor's
> [PATCH v2 00/35] acpi: refactor error prone build_header() and
> packed structures usage in ACPI tables
FYI: I'm preparing to post v3 today, with so far received feedback
addressed. Change that will affect 3/3 is
s/acpi_init_table|acpi_table_composed/acpi_table_begin|acpi_table_end/
> The DBG2 specification can be found at
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table.
>
> DBG2 is mandated by ARM SBBR since its v1.0 release (the rationale
> behind is Windows requires it on all systems).
>
> The DBG2 is used to describe a debug port, used by the kernel debugger.
>
> This series and its dependency can be found at
> https://github.com/eauger/qemu.git
> branch: dbg2-v2-igor-v2-fix
>
> History:
> v1 -> v2:
> - rebase on top of Igor's series and use acpi_init_table/acpi_table_composed
> and build_append_int_noprefix()
>
> Eric Auger (3):
> tests/acpi: Add void table for virt/DBG2 bios-tables-test
> bios-tables-test: Generate reference table for virt/DBG2
> hw/arm/virt_acpi_build: Generate DBG2 table
I'd swap 2/3 and 3/3, so it would be obvious where DBG2 comes from.
>
> hw/arm/virt-acpi-build.c | 64 +++++++++++++++++++++++++++++++++++++-
> tests/data/acpi/virt/DBG2 | Bin 0 -> 87 bytes
> 2 files changed, 63 insertions(+), 1 deletion(-)
> create mode 100644 tests/data/acpi/virt/DBG2
>