qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson.build: Do not look for VNC-related libraries if have_s


From: Paolo Bonzini
Subject: Re: [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set
Date: Tue, 7 Sep 2021 14:52:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 06/09/21 17:39, Thomas Huth wrote:
When running "./configure --static --disable-system" there is currently
a warning if the static version of libpng is missing:

  WARNING: Static library 'png16' not found for dependency 'libpng', may not
  be statically linked

Since it does not make sense to look for the VNC-related libraries at all
when we're building without system emulator binaries, let's add a check
for have_system here to silence this warning.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 7e58e6279b..f07236d947 100644
--- a/meson.build
+++ b/meson.build
@@ -931,7 +931,7 @@ vnc = not_found
  png = not_found
  jpeg = not_found
  sasl = not_found
-if not get_option('vnc').disabled()
+if have_system and not get_option('vnc').disabled()
    vnc = declare_dependency() # dummy dependency
    png = dependency('libpng', required: get_option('vnc_png'),
                     method: 'pkg-config', kwargs: static_kwargs)


Queued, thanks.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]