Re: [PATCH v2 1/2] migration: allow multifd for socket protocol only

[Juan Quintela]

Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
> multifd with unsupported protocol will cause a segment fault.
> (gdb) bt
>  #0  0x0000563b4a93faf8 in socket_connect (addr=0x0, errp=0x7f7f02675410) at 
> ../util/qemu-sockets.c:1190
>  #1 0x0000563b4a797a03 in qio_channel_socket_connect_sync
> (ioc=0x563b4d16e8c0, addr=0x0, errp=0x7f7f02675410) at
> ../io/channel-socket.c:145
>  #2  0x0000563b4a797abf in qio_channel_socket_connect_worker 
> (task=0x563b4cd86c30, opaque=0x0) at ../io/channel-socket.c:168
>  #3  0x0000563b4a792631 in qio_task_thread_worker (opaque=0x563b4cd86c30) at 
> ../io/task.c:124
>  #4  0x0000563b4a91da69 in qemu_thread_start (args=0x563b4c44bb80) at 
> ../util/qemu-thread-posix.c:541
>  #5  0x00007f7fe9b5b3f9 in ?? ()
>  #6  0x0000000000000000 in ?? ()
>
> It's enough to check migrate_multifd_is_allowed() in multifd cleanup() and
> multifd setup() though there are so many other places using 
> migrate_use_multifd().
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>