Re: [PATCH v2 6/9] linux-user: Split safe-syscall macro into its own header

[Richard Henderson]

On 9/8/21 8:44 AM, Peter Maydell wrote:
> Split the safe-syscall macro from qemu.h into a new safe-syscall.h.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   linux-user/qemu.h         | 135 ---------------------------------
>   linux-user/safe-syscall.h | 154 ++++++++++++++++++++++++++++++++++++++
>   linux-user/syscall.c      |   1 +
>   3 files changed, 155 insertions(+), 135 deletions(-)
>   create mode 100644 linux-user/safe-syscall.h

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


> +#else
> +
> +/*
> + * Fallback for architectures which don't yet provide a safe-syscall assembly
> + * fragment; note that this is racy!
> + * This should go away when all host architectures have been updated.
> + */
> +#define safe_syscall syscall

All native tcg hosts have been updated.  All that is left are those for which we fall back 
to tci.  At what point do we drop the fallback and simply make this a build error?


r~